Move diagnostic tagging to 'pull diagnostics'#63858
Merged
CyrusNajmabadi merged 10 commits intodotnet:mainfrom Sep 12, 2022
Merged
Move diagnostic tagging to 'pull diagnostics'#63858CyrusNajmabadi merged 10 commits intodotnet:mainfrom
CyrusNajmabadi merged 10 commits intodotnet:mainfrom
Conversation
ghost
added
the
dibarbet
approved these changes
Sep 8, 2022
| cancellationToken).ConfigureAwait(false); | ||
|
|
||
| var isLiveUpdate = id is ISupportLiveUpdate; | ||
| var diagnostics = await _analyzerService.GetDiagnosticsForSpanAsync( |
CyrusNajmabadi
added a commit
to CyrusNajmabadi/roslyn
that referenced
this pull request
Nov 21, 2022
1 task
arunchndr
pushed a commit
that referenced
this pull request
Nov 30, 2022
Revert "Merge pull request #63858 from CyrusNajmabadi/pullDiags"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is what we're doing in LSP pull diagnostics already. This just moves our taggers to also work this way even when LSP pull diagnostics is off.